Re: dblink patches for comment

Joe Conway <mail@joeconway.com> writes:
> The attached addresses items#2 and 3 as listed by Bruce here:
>    http://momjian.us/cgi-bin/pgsql/joe

> I think it is consistent with the discussions we had a PGCon last week. 
> Any objections to me committing this for 8.4?

It's hard to review it without any docs that say what it's supposed to do.
(And you'd need to patch the docs anyway, eh?)

> On a side note, should I try to address items #1 & #4 for 8.4 as well? 
> Perhaps #4 yes since it is arguably a bug fix, but no to #1?

Yeah, my feeling too.  #1 is a new feature that was submitted too late
for 8.4.  I wouldn't have argued if you'd committed it anyway during
the commitfest, but it's definitely too late now.  But #4 seems like
a bugfix.
        regards, tom lane