Michael Paquier <michael@paquier.xyz> writes:
> On Fri, May 28, 2021 at 11:37:22AM -0400, Tom Lane wrote:
>> It's not clear to me how much of 7ca37fb you're envisioning
>> back-patching in (2). I think it'd be best to back-patch
>> only the addition of pgwin32_setenv, and then let the gssapi
>> code use it. In that way, if there's anything wrong with
>> pgwin32_setenv, we're only breaking code that never worked
>> on Windows before anyway.
> Just to be clear, for 2) I was thinking to pick up the minimal parts
> you have changed in win32env.c and add src/port/setenv.c to add the
> fallback implementation of setenv(), without changing anything else.
> This also requires grabbing the small changes within pgwin32_putenv(),
> visibly.
What I had in mind was to *only* add pgwin32_setenv, not setenv.c.
There's no evidence that any other modern platform lacks setenv.
Moreover, there's no issue in these branches unless your platform
lacks setenv yet has GSS support.
regards, tom lane