Re: Improve tab completion for COPY

On Tue, 10 Jun 2025 11:15:09 +0900
torikoshia <torikoshia@oss.nttdata.com> wrote:

> On 2025-06-03 17:58, Yugo Nagata wrote:
> > Thank you for updating the patch.
> > It looks good and I confirmed that this works as expected.
> 
> Thanks for your review!
> 
> BTW this is a small patch, but it does two things:
> 
> (1) adds tab completion support for the REJECT_LIMIT option, which was 
> introduced in v18
> (2) splits the tab completion logic between COPY FROM and COPY TO to 
> reflect their different options.
> 
> While maybe (2) should be postponed to v19 or later, I think it would be 
> better to include (1) in v18.
> So I’ve split them into separate patches accordingly.

I am not convinced whether (1) should be regarded as a v18-related oversight
or a new feature, but if this is a oversight, this should be added to the open
items list?

https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>