Re: Stack overflow issue
От | Andres Freund |
---|---|
Тема | Re: Stack overflow issue |
Дата | |
Msg-id | 20240417173528.257mnitlhncdxx23@awork3.anarazel.de обсуждение исходный текст |
Ответ на | Re: Stack overflow issue (Alexander Korotkov <aekorotkov@gmail.com>) |
Список | pgsql-hackers |
Hi, On 2024-04-17 14:39:14 +0300, Alexander Korotkov wrote: > On Wed, Apr 17, 2024 at 2:37 PM Alexander Korotkov <aekorotkov@gmail.com> wrote: > > I've invested more time into polishing this. I'm intended to push > > this. Could you, please, take a look before? > > Just after sending this I spotted a typo s/untill/until/. The updated > version is attached. Nice, I see you moved the code back to "where it was", the diff to 16 got smaller this way. > + /* > + * Repeatedly call CommitTransactionCommandInternal() until all the work > + * is done. > + */ > + while (!CommitTransactionCommandInternal()); Personally I'd use { } instead of just ; here. The above scans weirdly for me. But it's also not important. Greetings, Andres Freund
В списке pgsql-hackers по дате отправления: