On Wed, Mar 27, 2024 at 05:10:13PM -0400, Tom Lane wrote:
> Shouldn't "i" be declared uint32, since nelem is?
Yes, that's a mistake.
> BTW, I wonder why these functions don't declare their array
> arguments like "const uint32 *base".
They probably should. I don't see any reason not to, and my compiler
doesn't complain, either.
> LGTM otherwise, and I like the fact that the #if structure
> gets a lot less messy.
Thanks for reviewing. I've attached a v2 that I intend to commit when I
get a chance.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com