On Sun, Jan 21, 2024 at 09:51:18PM -0600, Nathan Bossart wrote:
> I did notice a cfbot failure [0]. After a quick glance, I'm assuming this
> is caused by the memcpy() in insert_into_bucket(). Even if the string is
> short, it will copy the maximum key size, which is bad. So, 0002 is
> totally broken at the moment, and we'd need to teach insert_into_bucket()
> to strcpy() instead for string keys to fix it. Perhaps we could add a
> field to dshash_parameters for this purpose...
I attempted to fix this in v2 of the patch set.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com