Re: BUG #18241: PushTransaction may cause Standby to execute ItemIdMarkDead

At Mon, 11 Dec 2023 20:13:23 +0800, "feichanghong" <feichanghong@qq.com> wrote in 
> > We have analyzed the cause of the problem: The value of
> > IndexScanDesc->xactStartedInRecovery is a key condition for determining
> > whether an index item can be marked as DEAD. And it depends on
> > CurrentTransactionState->startedInRecovery. However, PushTransaction does
> > not assign a value to startedInRecovery when modifying
> > CurrentTransactionState.
> The attached patch has been verified to resolve the mentioned issue.

This appears to be a bug that has existed for a long time since commit
efc16ea520 (in 2009). Your fix looks correct to me, but as for me, the
comment is not particularly necessary, and it would be sufficient to
insert the new line in the location according to the member order
within TransactionStateData.

I have briefly checked and found no issues with other struct members
of TransactionStateData.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center