On Thu, Nov 23, 2023 at 08:05:26AM +0000, Xiang Gao wrote:
> On Date: Wed, 22 Nov 2023 15:06:18PM -0600, Nathan Bossart wrote:
>>pg_crc32c_armv8.o: CFLAGS += ${CFLAGS_CRC} ${CFLAGS_CRYPTO}
>
> It does not work correctly. CFLAGS ='-march=armv8-a+crc,
> -march=armv8-a+crypto', what actually works is '-march=armv8-a+crypto'.
>
> We set a new variable CLAGS_CRC_CRYPTO,In configure.ac,
>
> If test x"$CFLAGS_CRC" != x"" || test x"CFLAGS_CRYPTO" != x""; then
> CLAGS_CRC_CRYPTO = '-march=armv8-a+crc+crypto'
> fi
>
> then in makefile,
> pg_crc32c_armv8.o: CFLAGS +=${ CLAGS_CRC_CRYPTO }
Ah, I see. We need to append +crc and/or +crypto based on what the
compiler understands. That seems fine to me...
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com