Re: Using defines for protocol characters

Поиск
Список
Период
Сортировка
От Tatsuo Ishii
Тема Re: Using defines for protocol characters
Дата
Msg-id 20230804.042552.247869841063892380.t-ishii@sranhm.sra.co.jp
обсуждение исходный текст
Ответ на Using defines for protocol characters  (Dave Cramer <davecramer@gmail.com>)
Ответы Re: Using defines for protocol characters
Список pgsql-hackers
Дерево обсуждения 
> Greetings,
> 
> Attached is a patch which introduces a file protocol.h. Instead of using
> the actual characters everywhere in the code this patch names the
> characters and removes the comments beside each usage.

> +#define DESCRIBE_PREPARED           'S'
> +#define DESCRIBE_PORTAL             'P'

You use these for Close message as well. I don't like the idea because
Close is different message from Describe message.

What about adding following for Close too use them instead?

#define CLOSE_PREPARED           'S'
#define CLOSE_PORTAL             'P'

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

В списке pgsql-hackers по дате отправления: