Re: [PATCH] Missing dep on Catalog.pm in meson rules

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: [PATCH] Missing dep on Catalog.pm in meson rules
Дата
Msg-id 20230616211628.3wxxt2cisexqrakq@awork3.anarazel.de
обсуждение исходный текст
Ответ на Re: [PATCH] Missing dep on Catalog.pm in meson rules  (Andrew Dunstan <andrew@dunslane.net>)
Ответы Re: [PATCH] Missing dep on Catalog.pm in meson rules  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Список pgsql-hackers
Hi,

On 2023-06-16 16:20:14 -0400, Andrew Dunstan wrote:
> Unless I'm misunderstanding, this doesn't look terribly feasible to me. You
> can only get at %INC by loading the module, which in many cases will have
> side effects.

I was envisioning using %INC after the use/require block - I don't think our
scripts load additional modules after that point?


> And then you would also need to filter out things loaded that
> are not our artefacts (e.g. Catalog.pm loads File::Compare).

I don't think we would need to filter the output. This would just be for a
build dependency file. I don't see a problem with rerunning genbki.pl et al after
somebody updates File::Compare?

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Geoghegan
Дата:
Сообщение: Adding further hardening to nbtree page deletion
Следующее
От: David Zhang
Дата:
Сообщение: Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH