Re: pgsql: Allow logical decoding on standbys

Hi,

On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote:
> > Allow logical decoding on standbys
> 
> This adds the following error message.
> 
> +    errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary")));
> 
> We alredy have a nearly identical message as follows.
> 
> > errmsg("logical decoding requires wal_level >= logical")));
> 
> And we used to writte this kind of conditions, like "wal_level >=
> logical", using a mathematical operator. Don't we need to unify them?

I guess. It doesn't seem particularly important, but why not.


> And, a nearby commit addds the following message.
> 
> +            appendStringInfo(&err_detail, _("Logical decoding on standby requires wal_level to be at least logical
onthe primary server"));
 
> 
> This is omitting the indefinite article before "standby". I'm not sure
> what to do about it but feel like we don't need it here.

I don't think we need it either, but I'm not a native speaker.

Greetings,

Andres Freund