Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te

Hi,

On 2023-04-06 19:52:55 +0000, Tom Lane wrote:
> Fix ts_headline() edge cases for empty query and empty search text.

Unfortunately there appears to be some portability issue with this. Causes a
test output difference on macos. Noticed it when testing something I was about
to push, and I was very confused for a second how my change could have a
portability aspect :)

https://cirrus-ci.com/build/6629557554380800

https://api.cirrus-ci.com/v1/artifact/task/4764833480966144/testrun/build/testrun/regress/regress/regression.diffs

diff -U3 /Users/admin/pgsql/src/test/regress/expected/tsearch.out
/Users/admin/pgsql/build/testrun/regress/regress/results/tsearch.out
--- /Users/admin/pgsql/src/test/regress/expected/tsearch.out    2023-04-06 20:03:11
+++ /Users/admin/pgsql/build/testrun/regress/regress/results/tsearch.out    2023-04-06 20:05:56
@@ -2133,6 +2133,9 @@
 NOTICE:  text-search query doesn't contain lexemes: ""
 LINE 2: '', ''::tsquery);
             ^
+NOTICE:  text-search query doesn't contain lexemes: ""
+LINE 2: '', ''::tsquery);
+            ^
  ts_headline 
 -------------

Sure looks like somehow there's duplicate NOTICEs?

Greetings,

Andres Freund