Hi,
On 2023-03-30 12:28:57 +0700, John Naylor wrote:
> On Thu, Mar 30, 2023 at 10:02 AM Andres Freund <andres@anarazel.de> wrote:
> > Attached is v6. Changes:
>
> 0006:
>
> + ereport(ERROR,
> + errcode_for_file_access(),
> + errmsg("could not extend file \"%s\" with posix_fallocate():
> %m",
> + FilePathName(v->mdfd_vfd)),
> + errhint("Check free disk space."));
>
> Portability nit: mdzeroextend() doesn't know whether posix_fallocate() was
> used in FileFallocate().
Fair point. I would however like to see a different error message for the two
ways of extending, at least initially. What about referencing FileFallocate()?
Greetings,
Andres Freund