Re: Add pg_walinspect function with block info columns

At Sat, 25 Mar 2023 12:12:50 +0900, Michael Paquier <michael@paquier.xyz> wrote in 
> On Thu, Mar 23, 2023 at 10:54:40PM +0530, Bharath Rupireddy wrote:
>         OUT reltablespace oid,
>         OUT reldatabase oid,
>         OUT relfilenode oid,
>         OUT relblocknumber int8,
> +       OUT blockid int2,
> +    OUT start_lsn pg_lsn,
> +    OUT end_lsn pg_lsn,
> +    OUT prev_lsn pg_lsn,
> 
> I'd still put the LSN data before the three OIDs for consistency with
> the structures, though my opinion does not seem to count much..

I agree with Michael on this point. Also, although it may not be
significant for SQL, the rows are output in lsn order from the
function.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center