Hi,
On 2023-03-09 12:15:16 -0800, Mark Dilger wrote:
> > Somewhat random note:
> >
> > Is it intentional that we VACUUM FREEZE test ROWCOUNT times? That's
> > effectively O(ROWCOUNT^2), albeit with small enough constants to not really
> > matter. I don't think we need to insert the rows one-by-one either. Changing
> > that to a single INSERT and FREEZE shaves 10-12% off the tests. I didn't
> > change that, but we also fire off a psql for each tuple for heap_page_items(),
> > with offset $N no less. That seems to be another 500ms.
>
> I don't recall the reasoning. Feel free to optimize the tests.
Something like the attached.
I don't know enough perl to know how to interpolate something like
use constant ROWCOUNT => 17;
so I just made it a variable.
Greetings,
Andres Freund