Re: windows/meson cfbot warnings

Hi,

On 2023-02-25 16:45:38 -0600, Justin Pryzby wrote:
> Unrelated, but something else changed and now there's this.
> 
> https://cirrus-ci.com/task/6202242768830464
> 
> [20:10:34.310] c:\cirrus>call sh -c 'if grep ": warning " build.txt; then exit 1; fi; exit 0' 
> [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition
> [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition
> [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition
> [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition

Hm, odd.

There's a bit more context about the warning in the output:

[21:43:58.782] [1509/2165] Compiling C object src/pl/plpython/plpython3.dll.p/plpy_exec.c.obj
[21:43:58.782] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition
[21:43:58.924] src/pl/plpython/plpython3.dll.p/meson_pch-c.c: note: see previous definition of 'MS_WIN64'

I suspect one would have to look at the external source files to find where
it's also defined. The way the warning is triggered it seems to have to be
predefined somewhere in/below postgres.h.

It might be that we'll get more information after disabling precompiled headers.

Greetings,

Andres Freund