Re: meson and sslfiles.mk in src/test/ssl/

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: meson and sslfiles.mk in src/test/ssl/
Дата
Msg-id 20230222193309.liaziswwnwl2y7mp@awork3.anarazel.de
обсуждение исходный текст
Ответ на Re: meson and sslfiles.mk in src/test/ssl/  (Jacob Champion <jchampion@timescale.com>)
Ответы Re: meson and sslfiles.mk in src/test/ssl/  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Hi,

On 2023-02-22 09:42:54 -0800, Jacob Champion wrote:
> I'm happy to contribute cycles to a Meson port when you're ready for
> it. From a skim it seems like maybe in-source generation isn't a focus for
> Meson [1]. They might encourage us to write custom Python for it anyway?

You'd normally just invoke commands for updating sources as run_target()s, not
custom targets. Or generate them in the build tree via custom_target() and
then copy to the source tree via a run_target().

For this case I think it'd suffice to add a run target that does something
like
make -C ~/src/postgresql/src/test/ssl/ -f ~/src/postgresql/src/test/ssl/sslfiles.mk sslfiles OPENSSL=openssl

obviously with the necessary things being replaced by the relevant variables.


sslfiles.mk doesn't depend on the rest of the buildsystem, and is a rarely
executed command, so I don't see a problem with using make to update the
files. At least for a long while.

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Nathan Bossart
Дата:
Сообщение: Re: Reducing connection overhead in pg_upgrade compat check phase
Следующее
От: Nathan Bossart
Дата:
Сообщение: Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has)