Re: make_ctags: use -I option to ignore pg_node_attr macro
| От | Tatsuo Ishii |
|---|---|
| Тема | Re: make_ctags: use -I option to ignore pg_node_attr macro |
| Дата | |
| Msg-id | 20230208.092034.1819747511154080382.t-ishii@sranhm.sra.co.jp обсуждение исходный текст |
| Ответ на | Re: make_ctags: use -I option to ignore pg_node_attr macro (Yugo NAGATA <nagata@sraoss.co.jp>) |
| Ответы |
Re: make_ctags: use -I option to ignore pg_node_attr macro
|
| Список | pgsql-hackers |
>> The patch drops support for "-n" option :-< >> >> Attached is the patch by fixing make_ctags (make_etags is not >> touched). >> >> If Exuberant-type ctags is available, use it (not changed). >> If Exuberant-type ctags is not available, try old ctags (not changed). >> If the old ctags does not support "-e" option, try etags (new). > > I am not sure if this is good way to check if ctags supports "-e" or not. > > + then ctags --version 2>&1 | grep -- -e >/dev/null > > Perhaps, "--help" might be intended rather than "--version" to check > supported options? Yeah, that was my mistake. > Even so, ctags would have other option whose name contains > "-e" than Emacs support, so this check could end in a wrong result. Therefore, > it seems to me that it is better to check immediately if etags is available > in case that we don't have Exuberant-type ctags. That makes sense. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
В списке pgsql-hackers по дате отправления: