Re: Partial aggregates pushdown
От | Andres Freund |
---|---|
Тема | Re: Partial aggregates pushdown |
Дата | |
Msg-id | 20221207185943.g3pkqseovvrk2n2e@awork3.anarazel.de обсуждение исходный текст |
Ответ на | RE: Partial aggregates pushdown ("Fujii.Yuki@df.MitsubishiElectric.co.jp" <Fujii.Yuki@df.MitsubishiElectric.co.jp>) |
Ответы |
RE: Partial aggregates pushdown
|
Список | pgsql-hackers |
Hi, On 2022-12-05 02:03:49 +0000, Fujii.Yuki@df.MitsubishiElectric.co.jp wrote: > > Attaching minor fixes. I haven't proof-read all comments (but perhaps, they > > need attention from some native speaker). > Thank you. I fixed according to your patch. > And I fixed have proof-read all comments and messages. cfbot complains about some compiler warnings when building with clang: https://cirrus-ci.com/task/6606268580757504 deparse.c:3459:22: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if ((node->aggsplit == AGGSPLIT_SIMPLE)) { ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ deparse.c:3459:22: note: remove extraneous parentheses around the comparison to silence this warning if ((node->aggsplit == AGGSPLIT_SIMPLE)) { ~ ^ ~ deparse.c:3459:22: note: use '=' to turn this equality comparison into an assignment if ((node->aggsplit == AGGSPLIT_SIMPLE)) { ^~ = Greetings, Andres Freund
В списке pgsql-hackers по дате отправления: