Re: [RFC] building postgres with meson - v13
| От | Andres Freund |
|---|---|
| Тема | Re: [RFC] building postgres with meson - v13 |
| Дата | |
| Msg-id | 20221207032501.krclzqro6evqyzas@awork3.anarazel.de обсуждение исходный текст |
| Ответ на | Re: [RFC] building postgres with meson - v13 (Peter Geoghegan <pg@bowt.ie>) |
| Список | pgsql-hackers |
Hi, On 2022-09-26 14:15:35 -0700, Peter Geoghegan wrote: > On Mon, Sep 26, 2022 at 1:27 PM Andres Freund <andres@anarazel.de> wrote: > > > Some feedback: > > > * I gather that "running" as it appears in commands like "meson test > > > --setup running" refers to a particular setup named "running", that > > > you invented as part of creating a meson-ish substitute for > > > installcheck. Can "running" be renamed to something that makes it > > > obvious that it's a Postgres thing, and not a generic meson thing? > > > > Yes. The only caveat is that it makes lines longer, because it's included in > > the printed test line (there's no real requirement to have the test suite and > > the setup named the same,b ut it seems confusing not to) > > Probably doesn't have to be too long. And I'm not sure of the details. > Just a small thing from my point of view. Attached is an updated version of that patch. I left the name as 'running' because a postgres- or pg- prefix felt to awkward. This just adds fairly minimal documentation for the 'running' setup, while we now have some basic docs for building with meson, we don't yet have a "translation" of regress.sgml. Not sure how to structure that best, either. I plan to commit that soon. This likely isn't the be-all-end-all, but it's quite useful as-is. Greetings, Andres Freund
Вложения
В списке pgsql-hackers по дате отправления: