Re: A doubt about a newly added errdetail

Поиск
Список
Период
Сортировка
От Kyotaro Horiguchi
Тема Re: A doubt about a newly added errdetail
Дата
Msg-id 20220928.150034.1325913962801104491.horikyota.ntt@gmail.com
обсуждение исходный текст
Ответ на Re: A doubt about a newly added errdetail  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: A doubt about a newly added errdetail  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
At Tue, 27 Sep 2022 12:19:35 +0200, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote in 
> Yeah, since you're changing another word in that line, it's ok to move
> the parameter line off-string.  (If you were only changing the parameter
> to %s and there was no message duplication, I would reject the patch as
> useless.)

I'm fine with that. By the way, related to the area, I found the
following error messages.

>     errmsg("publication \"%s\" is defined as FOR ALL TABLES",
>            NameStr(pubform->pubname)),
>     errdetail("Schemas cannot be added to or dropped from FOR ALL TABLES publications.")));

It looks tome that the errmsg and errordetail are reversed. Isn't the following order common?

>     errmsg("schemas cannot be added to or dropped from publication \"%s\".",
>            NameStr(pubform->pubname)),
>     errdetail("The publication is defined as FOR ALL TABLES.")));

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



В списке pgsql-hackers по дате отправления:

Предыдущее
От: "kuroda.hayato@fujitsu.com"
Дата:
Сообщение: RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Следующее
От: Thomas Munro
Дата:
Сообщение: Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?