Re: Custom tuplesorts for extensions

Поиск
Список
Период
Сортировка
От Justin Pryzby
Тема Re: Custom tuplesorts for extensions
Дата
Msg-id 20220724232305.GH7789@telsasoft.com
обсуждение исходный текст
Ответ на Re: Custom tuplesorts for extensions  (Alexander Korotkov <aekorotkov@gmail.com>)
Ответы Re: Custom tuplesorts for extensions
Список pgsql-hackers
Note that 0001+0002 (without the others) incurs warnings:

$ time { make -j4 clean; make -j4; } >/dev/null
tuplesort.c:1883:9: warning: unused variable 'i' [-Wunused-variable]
tuplesort.c:1955:10: warning: unused variable 'i' [-Wunused-variable]
tuplesort.c:2026:9: warning: unused variable 'i' [-Wunused-variable]
tuplesort.c:2103:10: warning: unused variable 'i' [-Wunused-variable]

(I wondered in the past if cfbot should try to test for clean builds of subsets
of patchsets, and it came up recently with the JSON patches.)

Also, this comment has some bad indentation:

* Set state to be consistent with never trying abbreviation.

-- 
Justin



В списке pgsql-hackers по дате отправления: