Re: failures in t/031_recovery_conflict.pl on CI
От | Andres Freund |
---|---|
Тема | Re: failures in t/031_recovery_conflict.pl on CI |
Дата | |
Msg-id | 20220412184913.3wrt4olkdiqvicsj@alap3.anarazel.de обсуждение исходный текст |
Ответ на | Re: failures in t/031_recovery_conflict.pl on CI (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: failures in t/031_recovery_conflict.pl on CI
|
Список | pgsql-hackers |
Hi, On 2022-04-09 19:34:26 -0400, Tom Lane wrote: > Andres Freund <andres@anarazel.de> writes: > > It's been broken in different ways all the way back to 9.0, from what I can > > see, but I didn't check every single version. > > > Afaics the fix is to nuke the idea of doing anything substantial in the signal > > handler from orbit, and instead just set a flag in the handler. > > +1. This is probably more feasible given the latch infrastructure > than it was when that code was first written. What do you think about just reordering the disable_all_timeouts() to be before the got_standby_deadlock_timeout check in the back branches? I think that should close at least the most obvious hole. And fix it properly in HEAD? Greetings, Andres Freund
В списке pgsql-hackers по дате отправления: