Re: Add LZ4 compression in pg_dump
От | Justin Pryzby |
---|---|
Тема | Re: Add LZ4 compression in pg_dump |
Дата | |
Msg-id | 20220326183336.GJ28503@telsasoft.com обсуждение исходный текст |
Ответ на | Re: Add LZ4 compression in pg_dump (Justin Pryzby <pryzby@telsasoft.com>) |
Ответы |
Re: Add LZ4 compression in pg_dump
|
Список | pgsql-hackers |
On Sat, Mar 26, 2022 at 11:21:56AM -0500, Justin Pryzby wrote: > You're passing both the compression method *and* level. I think there should > be a structure which includes both. In the future, that can also handle > additional options. I'm not sure if there's anything worth saving, but I did that last year with 0003-Support-multiple-compression-algs-levels-opts.patch I sent a rebased copy off-list. https://www.postgresql.org/message-id/flat/20210104025321.GA9712@telsasoft.com#ca1b9f9d3552c87fa874731cad9d8391 | fatal("not built with LZ4 support"); | fatal("not built with lz4 support"); Please use consistent capitalization of "lz4" - then the compiler can optimize away duplicate strings. > 0004: The include should use <lz4.h> and not "lz4.h" Also, use USE_LZ4 rather than HAVE_LIBLZ4, per 75eae0908.
В списке pgsql-hackers по дате отправления: