Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

At Wed, 23 Mar 2022 11:51:25 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> The two places emit different outputs but the only difference is the
> delimiter between two blockrefs. (By the way, the current code forgets
> to insert a delimiter there).  So even if the function took "bool
> is_waldump", it is used only when appending a line delimiter.  It
> would be nicer if the "bool is_waldump" were "char *delimiter".
> Others might think differently, though..
> 
> So, the function looks like this.
> 
> StringInfo XLogBlockRefInfos(XLogReaderState *record, char *delimiter,
>                             uint32 &fpi_len);

By the way, xlog_block_info@xlogrecovery.c has the subset of the
function.  So the function can be shared with the callers of
xlog_block_info but I'm not sure it is not too-much...

StringInfo XLogBlockRefInfos(XLogReaderState *record, char *delimiter,
                               bool fpw_detail, uint32 &fpi_len);

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center