Hi,
On 2022-03-07 20:59:16 -0800, Andres Freund wrote:
> On 2022-03-07 23:39:39 -0500, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > wrasse says you were too quick to drop plpython_error_5.out.
>
> Does look like it. I'll try to find a distribution with an old python...
debian 8 did the trick.
The output from older python was in plpython_error.out the output from newer
python in plpython_error_5.out. Looked like python2 specific output.
Pushed.
I guess I should have grokked the _5 suffix - but the _3 suffix was used for
python3 specific content, so it wasn't obvious. Should we rename the file to
plpython_error_35.out?
A bit depressing to have a 500 line alternative output file for a one line
diff :(.
> > Otherwise looks pretty good so far.
>
> crake also failed. Looks like plpy_plpymodule.h needs to include plpython.h. A
> pre-existing issue that just didn't happen to cause problems...
Fixed that.
Greetings,
Andres Freund