Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

Hi,

On 2022-01-30 21:01:07 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2022-01-30 17:35:48 -0800, Andres Freund wrote:
> >> I see this broke on everywhere but master. Looking.
> 
> > Ugh. It's that we didn't backport pport.h.
> 
> Ooops.

I've pushed the quick fix of just using PERL_VERSION for now. That's, as
Ilmari noted, not necessarily future safe, but for now it'll work.


> > Unless somebody comes up with a better idea quickly I'm going use a plain
> > PERL_VERSION check in the backbranches. Might also be a good idea to backpatch
> > the above commit, but that requires more discussion than I want to leave the
> > buildfarm red for.
> 
> I think we oughta backport.  We didn't do so at the time because
> we thought it was mostly cosmetic/future-proofing, but evidently
> the future is now.
> 
> I can look into that tomorrow or so.

Cool. I can either do a revert of the set of commits just now afterwards, or
you can fold that into the backpatch...

Greetings,

Andres Freund