Re: pgsql: Refactor the sslfiles Makefile target for ease of use

i,

On 2021-10-27 21:57:42 +0200, Daniel Gustafsson wrote:
> > On 27 Oct 2021, at 16:37, Daniel Gustafsson <daniel@yesql.se> wrote:
> > 
> >> On 26 Oct 2021, at 19:41, Andres Freund <andres@anarazel.de> wrote:
> > 
> >> This fails during 'make clean' in a vpath build, because sslfiles.mk cannot be
> >> found. Probably just needs
> > 
> > It does in fact need that diff, but sslfiles.mk also needs to be taught about
> > the current $(srcdir) to properly function under VPATH for "make sslfiles".

I think that may previously also not have worked. I mostly care about getting
make clean to work again...


> Discussing this off-list with Jacob, and dabbling some more with it, this needs
> more thought.  It's not clear what make sslfiles should do in a VPATH build,
> and where, since the artefacts are both generated and distributed.

It's imo pretty clear that it'd need to put the files in the source directory.


> I've pushed the small fix to ensure "make clean" works as that's a much more
> common usecase, to allow for time to discuss "make sslfiles" on -hackers.

Cool!

Greetings,

Andres Freund