Re: wal stats questions

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: wal stats questions
Дата
Msg-id 20210326170745.rk3tj7hzqaklheix@alap3.anarazel.de
обсуждение исходный текст
Ответ на Re: wal stats questions  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Ответы Re: wal stats questions  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
Hi,

On 2021-03-25 16:37:10 +0900, Kyotaro Horiguchi wrote:
> On the other hand, the counters are incremented in XLogInsertRecord()
> and I think we don't want add instructions there.

I don't really buy this. Setting a boolean to true, in a cacheline
you're already touching, isn't that much compared to all the other stuff
in there. The branch to check if wal stats timing etc is enabled is much
more expensive.  I think we should just set a boolean to true and leave
it at that.

Greetings,

Andres Freund

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: invalid data in file backup_label problem on windows
Следующее
От: Andres Freund
Дата:
Сообщение: Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested.