Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Tue, Mar 23, 2021 at 12:12:03PM -0300, Álvaro Herrera wrote:
> On 2021-Mar-22, Bruce Momjian wrote:
> 
> > --- a/doc/src/sgml/ref/explain.sgml
> > +++ b/doc/src/sgml/ref/explain.sgml
> > @@ -136,8 +136,10 @@ ROLLBACK;
> >        the output column list for each node in the plan tree, schema-qualify
> >        table and function names, always label variables in expressions with
> >        their range table alias, and always print the name of each trigger for
> > -      which statistics are displayed.  This parameter defaults to
> > -      <literal>FALSE</literal>.
> > +      which statistics are displayed.  The query identifier will also be
> > +      displayed if one has been compute, see <xref
> > +      linkend="guc-compute-query-id"/> for more details.  This parameter
> > +      defaults to <literal>FALSE</literal>.
> 
> Typo here, "has been computed".

Good catch, fixed.

> Is the intention to commit each of these patches separately?

No, I was thinking of just doing a single commit.  Should I do three
commits?  I posted it as three patches since that is how it was posted
by the author, and reviewing is easier.  It also will need a catversion
bump.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.