Re: pgsql: Track total number of WAL records, FPIs and bytes generated in t

Hi,

On 2020-12-02 04:04:57 +0000, Fujii Masao wrote:
> Track total number of WAL records, FPIs and bytes generated in the cluster.
> 
> Commit 6b466bf5f2 allowed pg_stat_statements to track the number of
> WAL records, full page images and bytes that each statement generated.
> Similarly this commit allows us to track the cluster-wide WAL statistics
> counters.
> 
> New columns wal_records, wal_fpi and wal_bytes are added into the
> pg_stat_wal view, and reports the total number of WAL records,
> full page images and bytes generated in the , respectively.
> 
> Author: Masahiro Ikeda
> Reviewed-by: Amit Kapila, Movead Li, Kyotaro Horiguchi, Fujii Masao
> Discussion: https://postgr.es/m/35ef960128b90bfae3b3fdf60a3a860f@oss.nttdata.com


This is missing a catversion bump, due to the changes in view
names. Noticed that because I got errors like
 -- There must be only one record
 select count(*) = 1 as ok from pg_stat_wal;
- ok 
-----
- t
-(1 row)
-
+ERROR:  function return row and query-specified return row do not match
+DETAIL:  Returned row contains 5 attributes, but query expects 2.
 -- This is to record the prevailing planner enable_foo settings during
 -- a regression test run.

when running tests against a pre-existing cluster after rebasing a
development tree.

Greetings,

Andres Freund