Re: Proposed patch for key managment

On Mon, Dec  7, 2020 at 11:03:30AM +0900, Michael Paquier wrote:
> On Sat, Dec 05, 2020 at 10:42:05AM -0500, Bruce Momjian wrote:
> > On Sat, Dec  5, 2020 at 09:54:33PM +0900, Michael Paquier wrote:
> >> On Fri, Dec 04, 2020 at 10:52:29PM -0500, Bruce Momjian wrote:
> >>>      if (state->evpctx == NULL)
> >>>      {
> >>> -        explicit_bzero(state, sizeof(pg_cryptohash_state));
> >>> -        explicit_bzero(ctx, sizeof(pg_cryptohash_ctx));
> >>>  #ifndef FRONTEND
> >>>          ereport(ERROR,
> >>>                  (errcode(ERRCODE_OUT_OF_MEMORY),
> >> 
> >> And this original position is IMO more correct.
> > 
> > Do we even need them?
> 
> That's the intention to clean up things in a consistent way.

Ah, I see your point.  Added:

    https://github.com/postgres/postgres/compare/master...bmomjian:key.diff

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee