Re: pgsql: Add pg_relation_check_pages() to check on-disk pages of a relati

On Wed, Oct 28, 2020 at 12:26:29AM -0400, Tom Lane wrote:
> Seems to have some issues according to florican:
>
> 2020-10-28 00:04:53.191 EDT [27031:5] DETAIL:  Failed process was
> running: SELECT relname, failed_block_num FROM (SELECT relname,
> (pg_catalog.pg_relation_check_pages(oid)).*   FROM pg_class    WHERE
> relkind in ('r','i', 'm') AND oid >= 16384) AS s

Yes, thanks.  I was already investigating it.  No need for a
back-trace, I have been able to reproduce it here avec some -m32'ing
with gcc:
#1  0x566e0572 in fill_val (att=0x57d205c0, bit=0x0,
bitmask=0xff9c51e8, dataP=0xff9c521c, infomask=0x57d207e8, datum=0,
isnull=false) at heaptuple.c:287
#2  0x566e066e in heap_fill_tuple (tupleDesc=0x57d2053c,
values=0xff9c52b0, isnull=0xff9c52ae, data=0x57d207fd "",
data_size=28, infomask=0x57d207e8, bit=0x0)
at heaptuple.c:336
#3  0x566e2660 in heap_form_minimal_tuple
(tupleDescriptor=0x57d2053c, values=0xff9c52b0, isnull=0xff9c52ae)
at heaptuple.c:1412
#4  0x56d18e84 in tuplestore_putvalues (state=0x57d20648,
tdesc=0x57d2053c, values=0xff9c52b0, isnull=0xff9c52ae) at
tuplestore.c:756
#5  0x56c2b94b in check_relation_fork (tupdesc=0x57d2053c,
tupstore=0x57d20648, relation=0xeebf346c, forknum=MAIN_FORKNUM) at
pagefuncs.c:222
#6  0x56c2b779 in check_one_relation (tupdesc=0x57d2053c,
tupstore=0x57d20648, relid=16384,
single_forknum=InvalidForkNumber) at pagefuncs.c:148
#7  0x56c2b645 in pg_relation_check_pages (fcinfo=0x57d1c888) at
pagefuncs.c:104
--
Michael