Re: Documentation patch for backup manifests in protocol.sgml

On Tue, Aug 18, 2020 at 02:41:09PM +0200, Bernd Helmle wrote:
> Hi,
> 
> protocol.sgml describes the protocol messages received by a BASE_BACKUP
> streaming command, but doesn't tell anything about the additional
> CopyResponse data message containing the contents of the backup
> manifest (if requested) after having received the tar files. So i
> propose the attached to give a little more detail in this paragraph.
> 
>     Thanks, Bernd
> 

> diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
> index 8b00235a516..31918144b37 100644
> --- a/doc/src/sgml/protocol.sgml
> +++ b/doc/src/sgml/protocol.sgml
> @@ -2665,8 +2665,10 @@ The commands accepted in replication mode are:
>        <quote>ustar interchange format</quote> specified in the POSIX 1003.1-2008
>        standard) dump of the tablespace contents, except that the two trailing
>        blocks of zeroes specified in the standard are omitted.
> -      After the tar data is complete, a final ordinary result set will be sent,
> -      containing the WAL end position of the backup, in the same format as
> +      After the tar data is complete, and if a backup manifest was requested,
> +      another CopyResponse result is sent, containing the manifest data for the
> +      current base backup. In any case, a final ordinary result set will be
> +      sent, containing the WAL end position of the backup, in the same format as
>        the start position.
>       </para>

If someone can confirm this, I will apply it?  Magnus?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee