Re: [PATCH] Incremental sort (was: PoC: Partial sort)

On Sun, Mar 22, 2020 at 10:05:50PM -0400, James Coleman wrote:
>On Sun, Mar 22, 2020 at 8:54 PM Andreas Karlsson <andreas@proxel.se> wrote:
>>
>> On 3/23/20 1:33 AM, James Coleman wrote:
>> > So on the face of it we have a bit of a no-win situation. The function
>> > tuple_sort_method_name returns a const, but lappend wants a non-const.
>> > I'm not sure what the project style preference is here: we could cast
>> > the result as (char *) to drop the const qualifier, but that's frowned
>> > upon some places. Alternatively we could make a new non-const copy of
>> > string. Which is preferable in the postgres project style?
>>
>> The PostgreSQL has places where const is explicitly casted away with the
>> unconstify() macro, so unless you can find a better solution that is
>> probably an ok option.
>
>Thanks, that's exactly what I need!
>

Yeah, sorry I forgot to mention/fix the warning in the last review round.

BTW I think the comment for pathkeys_useful_for_ordering() needs
updating, it still claims it's all-or-nothing affair, but that's no
longer true I think.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services