Re: pgindent && weirdness

On Tue, Jan 14, 2020 at 05:30:21PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > I just ran pgindent over some patch, and noticed that this hunk ended up
> > in my working tree:
>  
> > -    if (IsA(leftop, Var) && IsA(rightop, Const))
> > +    if (IsA(leftop, Var) &&IsA(rightop, Const))
> 
> Yeah, it's been doing that for decades.  I think the triggering
> factor is the typedef name (Var, here) preceding the &&.
> 
> It'd be nice to fix properly, but I've tended to take the path
> of least resistance by breaking such lines to avoid the ugliness:
> 
>     if (IsA(leftop, Var) &&
>         IsA(rightop, Const))

In the past I would use a post-processing step after BSD indent to fix
up these problems.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +