Re: [PATCH] Remove twice assignment with var pageop (nbtree.c).

On Tue, Nov 26, 2019 at 01:45:10PM +0000, Ranier Vilela wrote:
> Same case on nbtpage.c at line 1637, with var opaque.
> make check, passed all 195 tests here with all commits.
> 
> Ranier Vilela

You were right about both of these, so removed in master.  I am
surprised no one else saw this before.

---------------------------------------------------------------------------

> diff --git a/src/backend/access/nbtree/nbtpage.c b/src/backend/access/nbtree/nbtpage.c
> index 268f869a36..144fefccad 100644
> --- a/src/backend/access/nbtree/nbtpage.c
> +++ b/src/backend/access/nbtree/nbtpage.c
> @@ -1634,8 +1634,6 @@ _bt_mark_page_halfdead(Relation rel, Buffer leafbuf, BTStack stack)
>       * delete the following item.
>       */
>      page = BufferGetPage(topparent);
> -    opaque = (BTPageOpaque) PageGetSpecialPointer(page);
> -
>      itemid = PageGetItemId(page, topoff);
>      itup = (IndexTuple) PageGetItem(page, itemid);
>      BTreeInnerTupleSetDownLink(itup, rightsib);
> 


-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +