Re: BUG #16039: PANIC when activating replication slots in Postgres12.0 64bit under Windows

Hi,

On 2019-10-09 13:42:07 +0900, Michael Paquier wrote:
> > Yuck :(. Luckily that's a pretty narrow case to hit.  We really need
> > windows coverage for this stuff. And also just general buildfarm
> > coverage, it's not like we're immune from bugs on unixoid OSs etiher.
> 
> test_decoding hits that easily for me, and we test that on Windows for
> some time now as there is a buildfarm module.  That's a bit depressing.

Well, that's because it intentionally tries to hit that case ;)

But yea, it's not good.

I think we really ought to remove the -F from pg_regress.c, and leave
that up to the caller. Right now it's just about impossible to
configure without patching the source, unless I miss something.


> >> Andres, others, any thoughts about this issue?  Are there any
> >> objections if I just fix it?
> > 
> > Not here.
> 
> Done this one.

Thanks.

Greetings,

Andres Freund