Re: pgsql: Support reloptions of enum type
От | Alvaro Herrera |
---|---|
Тема | Re: pgsql: Support reloptions of enum type |
Дата | |
Msg-id | 20190927011947.GA10059@alvherre.pgsql обсуждение исходный текст |
Ответ на | Re: pgsql: Support reloptions of enum type (Michael Paquier <michael@paquier.xyz>) |
Ответы |
Re: pgsql: Support reloptions of enum type
|
Список | pgsql-committers |
Hello, sorry I didn't notice this email. On 2019-Sep-26, Michael Paquier wrote: > This part from commit 773df88 is incorrect: > + /* > + * Set the default lock mode for this option. There is no actual way > + * for a module to enforce it when declaring a custom relation option, > + * so just use the highest level, which is safe for all cases. > + */ > + newoption->lockmode = AccessExclusiveLock; You're right, this was a merge blunder :-( Sorry about that. > Do you mind if I apply the attached to fix the issue? Or perhaps you > would prefer fixing the issue yourself? I noted some inconsistencies > with the rest while on it (please see attached). Thanks for fixing. It all looks correct to me. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-committers по дате отправления: