Re: amcheck verification for GiST

On 2019-Sep-06, Andrey Borodin wrote:

> Here's rebased version. Changes in v9:
> * adjust to usage of table_open
> * update new extension version
> * check for main fork presence in GiST check too

Cool.  On a quick eyeball, your new amcheck.h does not conform to our
conventions: it should not include postgres.h, and it should only
include other headers as needed in order for it to compile standalone (I
think you just need utils/relcache.h and storage/lockdefs.h).  All the
other headers needed for .c files should be in the corresponding .c
files, not in the .h.

Please don't split error messages (errmsg, errdetail etc) in multiple
lines; just leave the line run long (do put arguments beyond a long
format string into separate lines, though).  This improves greppability.
There are some other minor style violations -- nothing that would not be
fixed by pgindent.


Peter, Heikki, are you going to do [at least] one more round of
design/functional review?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services