On Tue, Aug 20, 2019 at 07:07:49PM -0700, Andres Freund wrote:
> On 2019-08-21 10:58:54 +0900, Michael Paquier wrote:
>> @@ -246,6 +232,18 @@ ParallelSlotsSetup(const char *dbname, const char *host, const char *port,
>> {
>> conn = connectDatabase(dbname, host, port, username, prompt_password,
>> progname, echo, false, true);
>> +
>> + /*
>> + * Fail immediately if trying to use an index in an unsupported
>> + * range. Doing a hard exit here is not beautiful, but that's
>> + * not worth complicating the logic.
>> + */
>
> "that's not worth" sounds odd to me in the above sentence. I don't quite
> get the half-hearted rewrite of the comment from pgbench.c.
What about just keeping the first sentence then? And this gives:
"Fail immediately if trying to use an index in an unsupported range."
--
Michael