Re: allow online change primary_conninfo
От | Andres Freund |
---|---|
Тема | Re: allow online change primary_conninfo |
Дата | |
Msg-id | 20190404021330.od4bmfyj3wdv5yhg@alap3.anarazel.de обсуждение исходный текст |
Ответ на | Re: allow online change primary_conninfo (Michael Paquier <michael@paquier.xyz>) |
Список | pgsql-hackers |
On 2019-04-04 11:06:05 +0900, Michael Paquier wrote: > On Thu, Apr 04, 2019 at 12:27:55AM +0300, Sergei Kornilov wrote: > > Not agree. Latest patch version perform walreceiver restart without > > switch to a different method as discussed. Here is no race condition > > between startup process and walreceiver because conninfo passed via > > WalRcvData struct as currently. I miss something important? > > Michael Paquier had no possibility to review latest implementation, > > but did not say this is totally wrong, just asked wait a rather > > close lookup. > > I agree with Sergei's statement here. He has sent a patch for review, > which I have looked up a bit, but not enough to provide a full review > unfortunately, and this even if I was listed as a reviewer of it. So > if somebody is to blame here, that's me. > > Of cource we can close this cf entry. I would be happy if someone > > else post proper implementation. And I can rework my implementation > > again, but I don’t know how the correct implementation should look > > or why latest implementation is wrong. > > Moving this patch to next CF is fine. Cool, sorry for the misunderstanding then.
В списке pgsql-hackers по дате отправления: