Re: allow online change primary_conninfo

Hi,

On 2019-03-25 12:32:21 +0400, David Steele wrote:
> On 3/4/19 7:19 AM, Michael Paquier wrote:
> > On Sat, Mar 02, 2019 at 01:49:51PM +0300, Sergei Kornilov wrote:
> > > This might be not the right way, but I can't think of a better way
> > > to not switch to a different method than split of lastSourceFailed
> > > processing and starting new source. Something like refactoring in
> > > first attached patch. I move RequestXLogStreaming logic from
> > > lastSourceFailed processing and add new pendingRestartSource
> > > indicator.
> > 
> > OK.  This needs a rather close lookup, and I am not actually sure that
> > you even need pendingRestartSource.  Please let me a couple of days
> > before coming back to you on 0001.
> > 
> > > Second patch is mostly the same as previous version but uses new
> > > pendingRestartSource mechanism instead of lastSourceFailed.
> > 
> > This, on the other hand, looks like the implementation we are looking
> > for based on the discussions which happened until now to have the
> > startup process handle the shutdown and restart of the WAL receiver.
> 
> Do you know when you'll have a chance to revisit this?

I think we unfortunately got to mark this as returned with
feedback. I've not done so, but just switched the entry to waiting on
author.

Greetings,

Andres Freund