Re: bgwriter_lru_maxpages limits in PG 10 sample conf

On Tue, Mar  5, 2019 at 12:24:14AM -0300, Alvaro Herrera wrote:
> On 2019-Mar-04, Bruce Momjian wrote:
> 
> > On Thu, Feb 28, 2019 at 10:28:44AM +0300, Sergei Kornilov wrote:
> > > Hello
> > > 
> > > postgresql.conf.sample was changed recently in REL_10_STABLE (commit ab1d9f066aee4f9b81abde6136771debe0191ae8)
> > > So config will be changed in next minor release anyway. We have another reason to not fix bgwriter_lru_maxpages
comment?
> > 
> > Frankly, I was surprised postgresql.conf.sample was changed in a back
> > branch since it will cause people who diff $PGDATA/postgresql.conf with
> > share/postgresql.conf.sample to see differences they didn't make.
> 
> I think the set of people that execute diffs of their production conf
> file against the sample file to be pretty small -- maybe even empty.  If
> you're really interested in knowing the changes you've done, you're more
> likely to use a version control system on the file anyway.

Well, if this is true, then we should all agree to backpatch to
postgresql.conf.sample more often.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +