Re: Wrong aggregate result when sorting by a NULL value

On 2018-11-04 18:49:40 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2018-11-04 11:19:59 -0500, Tom Lane wrote:
> >> Used-for-asserts-only problem.  Will fix.
> 
> > Thanks.  I wonder if we shouldn't turn Asserts() into something roughly
> > akin to if (0) {expr};. That way we'd not deal with errors about unused
> > variables anymore - we're not safe against unreachable code warnings
> > anyway.
> 
> Meh.  I'm unexcited about getting rid of one type of compiler warning by
> introducing another one.

It's impracticable to enable dead code warnings in postgres
anyway. There's way way too many of them (all the returns after
elog(ERROR) etc are enough to make it infeasible to change that).

Greetings,

Andres Freund