Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER
От | David Fetter |
---|---|
Тема | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER |
Дата | |
Msg-id | 20181024032623.GK6049@fetter.org обсуждение исходный текст |
Ответ на | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER (Michael Paquier <michael@paquier.xyz>) |
Ответы |
Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER
|
Список | pgsql-hackers |
On Wed, Oct 24, 2018 at 08:43:05AM +0900, Michael Paquier wrote: > On Tue, Oct 23, 2018 at 12:26:35PM +0100, Dagfinn Ilmari Mannsåker wrote: > > The last-minute change for CREATE (EVENT) TRIGGER to accept EXECUTE > > FUNCTION as well as EXECUTE PROCEDURE did not update the tab completion > > in psql to match. Please find attached two patches that do this for > > CREATE TRIGGER and CREATE EVENT TRIGGER, respectively. > > Yes, it would be nice to fix that. > > > To keep the duplication minimal, I've changed it from completing EXECUTE > > PROCEDURE as a single thing to just EXECUTE, and then completing > > FUNCTION or FUNCTION and PROCEDURE after that depending on the server > > version. > > + else if (HeadMatches("CREATE", "EVENT", "TRIGGER") && TailMatches("EXECUTE")) > + if (pset.sversion >= 110000) > + COMPLETE_WITH("FUNCTION", "PROCEDURE"); > + else > + COMPLETE_WITH("PROCEDURE"); > > PROCEDURE is documented as deprecated as of v11 for CREATE TRIGGER > and CREATE EVENT TRIGGER. Wouldn't it be better to just complete > with FUNCTION for a v11 or newer server? I think that we want to > encourage users to use EXECUTE FUNCTION if possible. +1 for not completing with syntax we've just deprecated. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
В списке pgsql-hackers по дате отправления: