Re: [PG_UPGRADE] 9.6 to 10.5

On Thu, Aug 16, 2018 at 04:41:04PM -0300, Martín Marqués wrote:
> 2018-08-16 14:58 GMT-03:00 Bruce Momjian <bruce@momjian.us>:
> > On Thu, Aug 16, 2018 at 12:36:20PM -0400, Bruce Momjian wrote:
> >> I think we just need to add an error message to say the server must be
> >> shut down as a _primary_ server, not as a standby server, and we can
> >> recommend to read the documentation on the use of rsync.
> >
> > Attached is a proposed patch.
> 
> The logic in the patch is ok, but I'd use a different error message,
> one that just mentions that you can only upgrade a primary node:
> 
> The source cluster was shut down while in recovery mode, but
> pg_upgrade expected a primary node.

Well, if people are hitting the error because they are using pg_upgrade
on standbys, I assume we should give them some instruction that you
should not do that, no?

> The error referring to the target node should be similar, although I
> can't think of how to phrase it without saying "how on earth did you
> get a standby for the target! RTFM!" :-D

Yeah, for consistency I made it match.  ;-)

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +