Re: remove ancient pre-dlopen dynloader code

On 2018-08-16 09:22:14 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > This now generates a super nitpicky warning on at at least some linux +
> > clang configurations. I use -Weverything plus a lot of -Wno-*, and this
> > change added:
> > dynloader.c:7:4: warning: ISO C requires a translation unit to contain at least one declaration
[-Wempty-translation-unit]
> 
> We've been seeing that (or equivalents) on other platforms for years,
> if not decades.  I can't get too excited about it really.

Yea, me neither.


> The lazy man's way to get rid of it would be to put something like
> "int bogus = 0;" in the empty dynloader.c files.  Better would be
> to not have the empty .c files at all, but I'm not sure how much
> we'd have to contort the Makefiles to support that.

If I had my druthers, we'd just remove all that configure magic for
selecting these files and just use ifdefs.  Personally I find it
occasionally that they're linked into place, rather than built under
their original name.

Greetings,

Andres Freund