On Fri, Jul 27, 2018 at 02:40:42PM +0000, Bossart, Nathan wrote:
> On 7/26/18, 11:16 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> I think I'm essentially suggesting what you have in 0002 but without
> the new RangeVarGetRelidExtended() callback. I've attached a modified
> version of 0002 that seems to fix the originally reported issue. (I
> haven't looked into any extra handling needed for ANALYZE or
> partitioned tables.) Running the same checks for all VACUUMs would
> keep things simple and provide a more uniform user experience.
Okay, let me check that. Your patch has at least an error in
get_all_vacuum_rels() where toast relations cannot be skipped.
>> The docs mentioned that shared catalogs are processed, so I did not
>> bother, but visibly your comment is that we could be more precise about
>> the ownership in this case? An attempt is attached.
>
> Sorry, I should have been clearer. But yes, your update is what I was
> thinking.
No problem. If there are no objections, I am going to fix the REINDEX
issue first and back-patch. Its patch is the least invasive of the
set.
--
Michael