Re: pgsql: Add wait event for fsync of WAL segments

On 2018-Jul-09, Tom Lane wrote:

> Michael Paquier <michael@paquier.xyz> writes:
> > On Sun, Jul 08, 2018 at 10:23:37PM +0200, Julien Rouhaud wrote:
> >> I just noticed that the number of rows for the IO wait event type
> >> documentation hasn't been updated, see
> >> https://www.postgresql.org/docs/devel/static/monitoring-stats.html#WAIT-EVENT-TABLE.
> >> Trivial patch attached.
> 
> > Thanks, Julien!  Fixed.  Indeed the table format was weird..
> 
> Hm, do we need that "morerows" thing at all?  It seems impossible
> that we'll remember to keep it up to date in future.  How do you
> even check that it's right now?

Maybe we should add an XML comment
<!-- remember to update "morerows" above -->
at the end of the table :-)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services